Skip to content

Conversation

@davidjamesstone
Copy link
Contributor

Proposed change

Jira ticket:

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@davidjamesstone davidjamesstone force-pushed the feature/DF-687-location-maps-eastingnorthing branch from b67c60d to 2fe0b77 Compare January 15, 2026 15:01
@davidjamesstone davidjamesstone force-pushed the feature/DF-687-location-maps-eastingnorthing branch from 2443026 to f37f9c0 Compare January 15, 2026 15:35
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

@davidjamesstone davidjamesstone marked this pull request as ready for review January 16, 2026 11:03
@davidjamesstone davidjamesstone merged commit c3d788c into feature/DF-680-location-maps-latlong Jan 16, 2026
24 checks passed
@davidjamesstone davidjamesstone deleted the feature/DF-687-location-maps-eastingnorthing branch January 16, 2026 11:04
davidjamesstone added a commit that referenced this pull request Jan 28, 2026
* Import the location styles in the correct file

* Add location field map styles

* Update the OS API KEY config to inform that it is used by both the maps and postcode lookup plugins

* Add class `app-location-field` and dataset attribute to the location field base template

* Add the new map plugin and client script

* Register the new map plugin

* Add defra-map dependency

* Sonar fixes (Define a constant instead of duplicating)

* Sonar fixes (No magic number)

* Sonar fixes (No magic number)

* Sonar fixes (use "return" consistently)

* Sonar fixes (out scope)

* Sonar fixes (No magic number)

* Sonar fixes (Explicit return value)

* Sonar fixes (Split it into smaller functions)

* Sonar fixes ("return" consistently)

* Sonar fixes (Split it into smaller functions)

* Add location maps client tests

* Fix formatting

* Add map service tests

* Delete map tile proxy routes (because there are other requests e.g. sprites)

* Add tests for map plugin routes

* Add shared client JS tests

* Add map proxy route tests

* Map prox test to cover no content type returned

* Add tile request transformer client tests

* Test to ensure initMaps only applies when there are location components on the page

* Test to ensure initMaps only applies when there are supported location components on the page

* Fix comment

* Sonar fixes (Use `export…from`)

* Sonar fixes (Prefer String.fromCodePoint)

* Add map routes JsDoc descriptions

* Update to latest defra-map

* Restructure location map tests

* Feature/DF-687 location maps easting & northing (#289)

* Add eastingnorthingfield to the list of supported location fields

* Add easting northing capability to location maps

* Remove unused osgrid

* Add easting and northing tests location map client tests

* Add map tests with initial field values

* Add OS grid reference to the location map

* Add OS grid reference to the location map tests

* Sonar fixes (Define a constant instead of duplicating this literal)

* Sonar fixes (Define a constant instead of duplicating this literal)

* Revert "Delete map tile proxy routes (because there are other requests e.g. sprites)"

This reverts commit 9bae11a.

* Add attribution to the dark and black/white styles

* Add VTS 3857 sprites

* Refactor to shared centerMap function

* Refactor to shared init map config center function

* Fix OsGridRef initial values test

* Add transformer test for raw.githubusercontent.com

* Add map dependency from new repo and stable branch

* Remove unused import

* Replace @defra/defra-map with @defra/interactive-map

* Replace @defra/defra-map with @defra/interactive-map in JSSoc and tests

* Update @defra/interactive-map to v0.0.3-alpha

* Update the interact plugin to use the new 'enable' method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants