-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/DF-687 location maps easting & northing #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidjamesstone
merged 5 commits into
feature/DF-680-location-maps-latlong
from
feature/DF-687-location-maps-eastingnorthing
Jan 16, 2026
Merged
Feature/DF-687 location maps easting & northing #289
davidjamesstone
merged 5 commits into
feature/DF-680-location-maps-latlong
from
feature/DF-687-location-maps-eastingnorthing
Jan 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b67c60d to
2fe0b77
Compare
2443026 to
f37f9c0
Compare
|
|
c3d788c
into
feature/DF-680-location-maps-latlong
24 checks passed
davidjamesstone
added a commit
that referenced
this pull request
Jan 28, 2026
* Import the location styles in the correct file
* Add location field map styles
* Update the OS API KEY config to inform that it is used by both the maps and postcode lookup plugins
* Add class `app-location-field` and dataset attribute to the location field base template
* Add the new map plugin and client script
* Register the new map plugin
* Add defra-map dependency
* Sonar fixes (Define a constant instead of duplicating)
* Sonar fixes (No magic number)
* Sonar fixes (No magic number)
* Sonar fixes (use "return" consistently)
* Sonar fixes (out scope)
* Sonar fixes (No magic number)
* Sonar fixes (Explicit return value)
* Sonar fixes (Split it into smaller functions)
* Sonar fixes ("return" consistently)
* Sonar fixes (Split it into smaller functions)
* Add location maps client tests
* Fix formatting
* Add map service tests
* Delete map tile proxy routes (because there are other requests e.g. sprites)
* Add tests for map plugin routes
* Add shared client JS tests
* Add map proxy route tests
* Map prox test to cover no content type returned
* Add tile request transformer client tests
* Test to ensure initMaps only applies when there are location components on the page
* Test to ensure initMaps only applies when there are supported location components on the page
* Fix comment
* Sonar fixes (Use `export…from`)
* Sonar fixes (Prefer String.fromCodePoint)
* Add map routes JsDoc descriptions
* Update to latest defra-map
* Restructure location map tests
* Feature/DF-687 location maps easting & northing (#289)
* Add eastingnorthingfield to the list of supported location fields
* Add easting northing capability to location maps
* Remove unused osgrid
* Add easting and northing tests location map client tests
* Add map tests with initial field values
* Add OS grid reference to the location map
* Add OS grid reference to the location map tests
* Sonar fixes (Define a constant instead of duplicating this literal)
* Sonar fixes (Define a constant instead of duplicating this literal)
* Revert "Delete map tile proxy routes (because there are other requests e.g. sprites)"
This reverts commit 9bae11a.
* Add attribution to the dark and black/white styles
* Add VTS 3857 sprites
* Refactor to shared centerMap function
* Refactor to shared init map config center function
* Fix OsGridRef initial values test
* Add transformer test for raw.githubusercontent.com
* Add map dependency from new repo and stable branch
* Remove unused import
* Replace @defra/defra-map with @defra/interactive-map
* Replace @defra/defra-map with @defra/interactive-map in JSSoc and tests
* Update @defra/interactive-map to v0.0.3-alpha
* Update the interact plugin to use the new 'enable' method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





Proposed change
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).